Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streams: use strict on _stream_wrap #1279

Conversation

brendanashworth
Copy link
Contributor

A Mostly Harmless™ change to enable 'use strict' mode in _stream_wrap,
bringing it in line with all the other modules.

A Mostly Harmless™ change to enable 'use strict' mode in _stream_wrap,
bringing it in line with /all/ the other modules.
@brendanashworth brendanashworth added the stream Issues and PRs related to the stream subsystem. label Mar 26, 2015
@mscdex
Copy link
Contributor

mscdex commented Mar 26, 2015

LGTM

@silverwind
Copy link
Contributor

LGTM, if this is the last .js without strict mode ;)

@yosuke-furukawa
Copy link
Member

LGTM2 :) I will merge this.

brendanashworth added a commit that referenced this pull request Mar 27, 2015
A Mostly Harmless™ change to enable 'use strict' mode in _stream_wrap, bringing it in line with /all/ the other modules.

PR-URL: #1279
Reviewed-By: Brian White (@mscdex) <mscdex@mscdex.net>
Reviewed-By: Roman Reiss (@silverwind) <me@silverwind.io>
Reviewed-By: Yosuke Furukawa (@yosuke-furukawa)
<yosuke.furukawa@gmail.com>
@yosuke-furukawa
Copy link
Member

merged in c8fa8cc

@bnoordhuis
Copy link
Member

@yosuke-furukawa Not to be that guy but the commit log of c8fa8cc has overly long lines.

@trevnorris
Copy link
Contributor

Also the author/email on Reviewed-by: should always be on one line. :)

@brendanashworth
Copy link
Contributor Author

Thanks for merging, I'm away right now.

@yosuke-furukawa
Copy link
Member

ooooops, thank you for comment. I think I should get accustomed to merging process...
I will be careful.

@Fishrock123
Copy link
Contributor

We don't normally have github names, so it'd just be
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
:)

@rvagg rvagg mentioned this pull request Mar 28, 2015
@brendanashworth brendanashworth deleted the add-use-strict-stream-wrap branch April 6, 2015 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants